Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Output.when #439

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add Output.when #439

merged 1 commit into from
Apr 9, 2024

Conversation

pawelprazak
Copy link
Contributor

fixes #435

@pawelprazak pawelprazak added area/core The SDK's core code area/api User visible API labels Apr 5, 2024
@pawelprazak pawelprazak added this to the 0.3.0 milestone Apr 5, 2024
@pawelprazak pawelprazak requested a review from lbialy April 5, 2024 09:53
@pawelprazak pawelprazak force-pushed the pprazak/add-output-when branch from 2d062b9 to 1a067e7 Compare April 5, 2024 09:54
lbialy
lbialy requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@lbialy lbialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one or two things

core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/test/scala/besom/internal/OutputTest.scala Outdated Show resolved Hide resolved
@pawelprazak pawelprazak force-pushed the pprazak/add-output-when branch 3 times, most recently from ad69e6a to b645044 Compare April 8, 2024 11:52
@pawelprazak pawelprazak requested a review from prolativ as a code owner April 8, 2024 12:26
@pawelprazak pawelprazak force-pushed the pprazak/add-output-when branch from e23b080 to b645044 Compare April 8, 2024 13:40
@pawelprazak pawelprazak force-pushed the pprazak/add-output-when branch from b645044 to b207e97 Compare April 8, 2024 13:43
@pawelprazak pawelprazak merged commit f4ba7cc into main Apr 9, 2024
2 checks passed
@pawelprazak pawelprazak deleted the pprazak/add-output-when branch April 9, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbialy lbialy lbialy approved these changes

@prolativ prolativ Awaiting requested review from prolativ

Assignees
No one assigned
Labels
area/api User visible API area/core The SDK's core code
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Add Output.when convenience method
2 participants
@pawelprazak @lbialy