Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traverse problem from #430, fix component API function too #441

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Fix traverse problem from #430, fix component API function too #441

merged 4 commits into from
Apr 8, 2024

Conversation

lbialy
Copy link
Collaborator

@lbialy lbialy commented Apr 8, 2024 •
edited by pawelprazak
Loading

Fixes #430

@pawelprazak pawelprazak self-requested a review April 8, 2024 09:24
pawelprazak
pawelprazak approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@pawelprazak pawelprazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! :)

@pawelprazak pawelprazak added area/core The SDK's core code area/api User visible API kind/bug Some behavior is incorrect or out of spec labels Apr 8, 2024
@pawelprazak pawelprazak added this to the 0.3.0 milestone Apr 8, 2024
@lbialy lbialy merged commit d88194a into main Apr 8, 2024
2 checks passed
@lbialy lbialy deleted the lbialy/issue-436-fix-430 branch April 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelprazak pawelprazak pawelprazak approved these changes

Assignees
No one assigned
Labels
area/api User visible API area/core The SDK's core code kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Exception upon traverse
2 participants
@lbialy @pawelprazak