besom-cfg initial checkin to monorepo #494
Conversation
lbialy
force-pushed
the
lbialy/besom-cfg-initial-checkin
branch
from
c4acf15 to
c470137
Compare
lbialy
force-pushed
the
lbialy/besom-cfg-initial-checkin
branch
from
985a4d0 to
7ea7860
Compare
| @@ -1,6 +1,7 @@ | |||
| # Big idea behind using a Justfile is so that we can have modules like in sbt. | |||
|
|
|||
| besom-version := `cat version.txt` | |||
| besom-cfg-version := `cat besom-cfg/version.txt` | |||
There was a problem hiding this comment.
I assume there is a reason behind versioning cfg separately, but wouldn't it make sense to align the versions, just for the sake of simplicity?
There was a problem hiding this comment.
no, it wouldn't, this stuff has and has to have a completely separate lifecycle
| //> using scala 3.3.3 | ||
|
|
||
| //> using dep com.lihaoyi::os-lib::0.9.3 | ||
| //> using dep org.virtuslab::besom-cfg:0.2.0-SNAPSHOT |
There was a problem hiding this comment.
this will be replaced by current besom version next time you run the version bump script, that's why I was suggesting the version alignment ;)
There was a problem hiding this comment.
so there has to be a way to provide exceptions in the version bump script
| import scala.quoted.* | ||
| import besom.cfg.k8s.syntax.* | ||
|
|
||
| // this is besom-cfg-kubernetes entrypoint |
There was a problem hiding this comment.
since this is the entrypoint, I'd strongly advice adding even the most barebones scaladoc :)
There was a problem hiding this comment.
I'll strongly consider that once besom-cfg is beyond a prototype
lbialy
force-pushed
the
lbialy/besom-cfg-initial-checkin
branch
from
7ea7860 to
ba01946
Compare
lbialy
force-pushed
the
lbialy/besom-cfg-initial-checkin
branch
from
89c569f to
67e46f6
Compare
No description provided.