Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 488 #502

Merged
merged 1 commit into from
May 24, 2024
Merged

fix issue 488 #502

merged 1 commit into from
May 24, 2024

Conversation

lbialy
Copy link
Collaborator

@lbialy lbialy commented May 24, 2024

This fixes problem with missing ResourceState for components due to A <: ComponentResource / ComponentBase split (Resources keeps instances of ComponentBase as keys, user can provide A <: ComponentResource as lookup value). Solved by exposing internally the ComponentBase dependency in any A <: ComponentResource and using it as lookup value in Resources.

Copy link
Collaborator Author

@lbialy lbialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmyself

@lbialy lbialy merged commit 5f55293 into main May 24, 2024
2 checks passed
@lbialy lbialy deleted the issue-488 branch May 24, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant