Required flags

[antoniaklja]

It would be nice to enforce required flags and validate them (if nil or empty) before executing any encrypt/decrypt action.

Few examples of required flags:
gcp: --location, --project, key, keyring
aws: --region, key-id
etc.

Unfortunately, library what we use doesn't support Required Flags.
urfave/cli#85 - issue is still open

[pawelprazak]

I kind of get the explanation in the upstream issue, params validation is more of a "business logic".

I'd implement it as preconditions in the command, e.g.:
genuinetools/reg@58cebba#diff-f6da2430393ce391e4517013b6d3a95bL14

[pdolega]

Yeah, that would obviously work 👍
(and is often the only way - e.g. when you have conditionally required flags).

Normally I guess the added benefit (of having this possible in library) is that:

• this check is implicit (obviously - that's the whole point)
• it gets automatically marked appropriately in --help messages

[pawelprazak]

Hmm we might want to look at this:

urfave/cli#140
urfave/cli#140 (comment)
https://github.com/urfave/cli#placeholder-values
urfave/cli#85 (comment)
urfave/cli#85 (comment)
urfave/cli#85 (comment)

[pawelprazak]

There's also a 4 yo PR ;)
urfave/cli#155

[pawelprazak]

we might as well migrate to cobra library (used by kubectl)

[coilysiren]

🎁 I come bearing gifts! 🎁 urfave/cli#819

[antoniaklja]

fixed in v0.2.3