Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ArchUnit 1.0.0 features/improvements in our tests #1212

Closed
PawelLipski opened this issue Oct 4, 2022 · 2 comments
Closed

Use new ArchUnit 1.0.0 features/improvements in our tests #1212

PawelLipski opened this issue Oct 4, 2022 · 2 comments
Labels
code quality Code quality good first issue Good for newcomers testing Relates to tests and testability wontfix This will not be worked on
Milestone

Comments

@PawelLipski
Copy link
Collaborator

    Potentially relevant changes:

Accesses from inside of lambdas are now correctly detected. Before, the origin was set as a synthetic method like lambda$xxx$123 instead. JavaAccess can now be queried for isDeclaredInLambda() to distinguish this from an access outside of a lambda (see TNG/ArchUnit#847; thanks a lot to @oberprah, @FrederikFinckh)

New methods codeUnits().should().onlyBeCalled().by{Classes/Methods/...}That(..)

Originally posted by @PawelLipski in #1211 (comment)

@PawelLipski PawelLipski added good first issue Good for newcomers testing Relates to tests and testability code quality Code quality labels Oct 4, 2022
@mkondratek
Copy link
Collaborator

Oh, I was just wondering whats wrong now

@PawelLipski
Copy link
Collaborator Author

I went through all ArchUnit tests, can't see any place where we'd clearly benefit from new APIs. Closing

@PawelLipski PawelLipski added this to the v3.1.0 milestone Oct 4, 2022
@PawelLipski PawelLipski added the wontfix This will not be worked on label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code quality good first issue Good for newcomers testing Relates to tests and testability wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants