Update dependencies #1211
Update dependencies #1211
Conversation
git-machete-bot
requested review from
MaciejG604 and
PawelLipski
as code owners
| @@ -117,7 +117,7 @@ public void inner_classes_should_not_be_instantiated_from_constructor_of_enclosi | |||
| new DescribedPredicate<JavaConstructorCall>( | |||
| "an inner class is instantiated in a constructor of the enclosing class") { | |||
| @Override | |||
| public boolean apply(JavaConstructorCall input) { | |||
There was a problem hiding this comment.
from https://github.com/TNG/ArchUnit/releases/tag/v1.0.0-rc1:
DescribedPredicatenow extends the JDK 8 Predicate, soapply(..)has to be replaced bytest(..)
I think it only required change to get it working. However, all the changes and features may be worth reviewing and possibly applied
There was a problem hiding this comment.
Potentially relevant changes:
Accesses from inside of lambdas are now correctly detected. Before, the origin was set as a synthetic method like lambda$xxx$123 instead. JavaAccess can now be queried for isDeclaredInLambda() to distinguish this from an access outside of a lambda (see TNG/ArchUnit#847; thanks a lot to @oberprah, @FrederikFinckh)
New methods codeUnits().should().onlyBeCalled().by{Classes/Methods/...}That(..)
There was a problem hiding this comment.
Accesses from inside of lambdas are now correctly detected
There was a problem hiding this comment.
somehow it lambdas pass this check:
if (method.getName().startsWith("access$") || method.getName().startsWith("lambda$")) {
return;
}There was a problem hiding this comment.
but we can now use:
if (call.isDeclaredInLambda()) {
// ignore
}There was a problem hiding this comment.
To be fixed within #1212
|
|
mkondratek
force-pushed
the
update-deps/5b1e835fce66e904a9446767948cf846
branch
3 times, most recently
from
5e3440e
to
01c15e8
Compare
mkondratek
force-pushed
the
update-deps/5b1e835fce66e904a9446767948cf846
branch
from
01c15e8
to
b5a6ca8
Compare
No description provided.