Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch-switch logic in github checkout-prs still not perfect :/ #541

Closed
PawelLipski opened this issue May 31, 2022 · 2 comments · Fixed by #546
Closed

Branch-switch logic in github checkout-prs still not perfect :/ #541

PawelLipski opened this issue May 31, 2022 · 2 comments · Fixed by #546
Assignees
Labels
github Relates to integration with GitHub usability Relates to user experience, clarity, learning curve, reducing confusion etc.
Milestone

Comments

@PawelLipski
Copy link
Collaborator

image

Well.... I'd simply expect for the PR #883 to be checked out 😅 and it doesn't happen

Same for g m github checkout-prs --by=mkondratek, I'd expect his only PR (#870) to be checked out, but it doesn't happen

@PawelLipski PawelLipski added github Relates to integration with GitHub usability Relates to user experience, clarity, learning curve, reducing confusion etc. labels May 31, 2022
@PawelLipski PawelLipski added this to the v3.10.1 milestone May 31, 2022
@amalota
Copy link
Contributor

amalota commented Jun 10, 2022

So the current logic doesn't switch the branch associated with the PR if that branch is already present in the managed branches. I propose to change it so that the branch will get checked out when:

  • there is only single PR that meets the requirements (checkout-prs SINLGE_PR_NR / --by=USER / --all / --mine) -> stays the same
  • it does not matter whether branch associated with that single PR is already present in the managed branches -> changed

@PawelLipski wdyt?

@PawelLipski
Copy link
Collaborator Author

Okay! let's proceed with the above ☝🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Relates to integration with GitHub usability Relates to user experience, clarity, learning curve, reducing confusion etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants