Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #479: git machete github * should work with custom GitHub URL #487

Merged
merged 31 commits into from
May 18, 2022
Merged

Issue #479: git machete github * should work with custom GitHub URL #487

merged 31 commits into from
May 18, 2022

Conversation

amalota
Copy link
Contributor

@amalota amalota commented Apr 8, 2022 •
edited
Loading

closes #479

@amalota amalota self-assigned this Apr 8, 2022
@amalota amalota changed the title init Issue #479: git machete github anno-prs work with custom GitHub URL Apr 8, 2022
@PawelLipski PawelLipski added this to the v3.9.0 milestone Apr 8, 2022
@amalota amalota added the bug Something isn't working label Apr 8, 2022
@PawelLipski PawelLipski linked an issue Apr 8, 2022 that may be closed by this pull request
git machete github anno-prs doesn't work with custom GitHub URL #479
Closed
amalota
amalota commented Apr 8, 2022
View reviewed changes
git_machete/git_operations.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed Apr 8, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
@PawelLipski PawelLipski added the github Relates to integration with GitHub label Apr 8, 2022
PawelLipski
PawelLipski reviewed Apr 9, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
@PawelLipski PawelLipski modified the milestones: v3.9.0, v3.10.0 Apr 23, 2022
PawelLipski
PawelLipski reviewed May 4, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 4, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 4, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
@amalota
Copy link
Contributor Author

amalota commented May 13, 2022

@PawelLipski @kgadek Result:
image

PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
tests/test_github.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
git_machete/docs.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
git_machete/docs.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
git_machete/docs.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 14, 2022
View reviewed changes
git_machete/docs.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 16, 2022
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 17, 2022
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 17, 2022
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 17, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
PawelLipski
PawelLipski reviewed May 17, 2022
View reviewed changes
git_machete/client.py Outdated Show resolved Hide resolved
@PawelLipski
Copy link
Collaborator

Tested locally, all seems to work as expected 🎉 Minor comments, almost ready to approve

@amalota amalota merged commit 91fc20b into develop May 18, 2022
@amalota amalota deleted the bug/anno_prs_custom_github_url branch May 18, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgadek kgadek kgadek left review comments

@PawelLipski PawelLipski PawelLipski approved these changes

Assignees

@amalota amalota

Labels
bug Something isn't working github Relates to integration with GitHub
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

git machete github anno-prs doesn't work with custom GitHub URL
4 participants
@amalota @codecov-commenter @PawelLipski @kgadek