Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fish custom git command completion support #993

Conversation

guyboltonking
Copy link
Contributor

@guyboltonking guyboltonking commented Jul 17, 2023

Possibly fixes #697; other testers welcome! Since fish-shell/fish-shell#7652, fish has automatically discovered custom git commands and sourced the completion for them. This means that workarounds like

# Caveat:
# > if the user types git-machete, then only git-machete.fish will be loaded, but you can trick
# > fish into still loading git.fish by adding a complete --do-complete="git " at the top
# - https://gitter.im/fish-shell/fish-shell?at=6176a4bacd4972068b6a0804
complete --do-complete="git "

...are no longer necessary.

@PawelLipski PawelLipski self-requested a review July 17, 2023 14:01
@PawelLipski PawelLipski added cli Relates to command-line interface bug Something isn't working labels Jul 17, 2023
@PawelLipski PawelLipski added this to the v3.17.7 milestone Jul 17, 2023
@PawelLipski PawelLipski changed the base branch from master to develop July 17, 2023 14:02
@PawelLipski
Copy link
Collaborator

(I've changed the PR base to develop from master)

@PawelLipski PawelLipski force-pushed the guy/use-fish-custom-git-completion-support branch from 560e2f0 to 02f7799 Compare July 17, 2023 14:05
@codecov-commenter
Copy link

Codecov Report

Merging #993 (02f7799) into develop (7c4770e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #993   +/-   ##
========================================
  Coverage    98.50%   98.50%           
========================================
  Files           12       12           
  Lines         3147     3147           
  Branches       703      703           
========================================
  Hits          3100     3100           
  Misses          29       29           
  Partials        18       18           

@PawelLipski PawelLipski merged commit 0517eb7 into VirtusLab:develop Jul 17, 2023
@PawelLipski
Copy link
Collaborator

Gr8 🎉 I'm gonna release that as v3.17.7, and then add git machete completion bash|zsh|fish command in a subsequent v3.18.0 release 📦

@guyboltonking guyboltonking deleted the guy/use-fish-custom-git-completion-support branch August 1, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Relates to command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fish completion suggests files/directories alongside commands
3 participants