Actionable diagnostics #1229

lwronski · 2022-08-03T08:04:16Z

The next part of changes that are necessary before the integration with Metals.

…nostic

modules/cli-options/src/main/scala/scala/cli/commands/VerbosityOptions.scala

alexarchambault

Ok for either squash-and-merge, or adjust format / reference doc in the first 6 commits, so that the "Fix scalafmt" one isn't necessary.

lwronski force-pushed the actionable-diagnostics branch 2 times, most recently from 4938397 to 3d868d1 Compare August 3, 2022 13:44

lwronski added 6 commits August 3, 2022 23:28

Fix counting end pos in using directives

a797602

Use persistent logger to forward diagnostics to bsp

35a624c

Use hint severity in ActionableDiagnostic

7fe2e10

Set source as scala-cli for diagnostic generated in scala-cli

4980e2d

Pass actionable diagnostics suggestion to related information in diag…

b343d91

…nostic

Fix printing hint diagnostic in command line

6311689

lwronski force-pushed the actionable-diagnostics branch 2 times, most recently from 2678b0b to de44e09 Compare August 3, 2022 15:37

Fix scalafmt

71954ef

lwronski force-pushed the actionable-diagnostics branch from de44e09 to 71954ef Compare August 3, 2022 16:05

lwronski requested a review from Gedochao August 3, 2022 16:43

lwronski marked this pull request as ready for review August 3, 2022 16:43

lwronski requested a review from wleczny August 3, 2022 16:43

Gedochao reviewed Aug 5, 2022

View reviewed changes

modules/cli-options/src/main/scala/scala/cli/commands/VerbosityOptions.scala Show resolved Hide resolved

lwronski assigned alexarchambault and unassigned alexarchambault Aug 16, 2022

lwronski requested review from alexarchambault and Gedochao August 16, 2022 15:08

Gedochao approved these changes Aug 19, 2022

View reviewed changes

alexarchambault approved these changes Aug 19, 2022

View reviewed changes

lwronski merged commit 1719919 into VirtusLab:main Aug 19, 2022

Gedochao added enhancement New feature or request IDE labels Aug 24, 2022

Provide feedback