Use millw launcher instead of running mill by cs #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
fix-idea-import-mill-bsp-json
branch
4 times, most recently
from
9940d14
to
eec420e
Compare
alexarchambault
approved these changes
Sep 20, 2022
When IntelliJ import scala-cli BSP project it creates mill-bsp.json with long path to mill, because coursier update java.class.path and set there all jar dependencies from mill. To fix it, scala-cli uses millw launcher which doesn't have so long java.class.path.
lwronski
force-pushed
the
fix-idea-import-mill-bsp-json
branch
from
eec420e
to
5a97089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IntelliJ import scala-cli BSP project it creates
mill-bsp.jsonwith long path to mill, because coursier updatejava.class.pathand set there all jar dependencies from mill. To fix it, scala-cli uses millw launcher which doesn't have so longjava.class.path.Mill read path to launcher from java.class.path.