Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of Scala version and turn off the -release flag for 2.12.x < 2.12.5 #1377

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

Gedochao
Copy link
Contributor

Fixes #1372
Fixes #1373

However, code still doesn't compile on Scala 2.12.0 and compiles infinitely on 2.12.4, which should be addressed separately.

@Gedochao Gedochao changed the title Fix calculation of Scala version for Scala 2.12.1 and turn off the -release flag for 2.12.x < 2.12.5 Fix calculation of Scala version and turn off the -release flag for 2.12.x < 2.12.5 Sep 20, 2022
@Gedochao Gedochao added the bug Something isn't working label Sep 20, 2022
@Gedochao Gedochao marked this pull request as ready for review September 20, 2022 07:54
@Gedochao Gedochao merged commit d363403 into VirtusLab:main Sep 20, 2022
@Gedochao Gedochao deleted the fix-scala-2.12.1-to-2.12.4 branch September 20, 2022 12:08
Comment on lines +831 to +832
if params.scalaVersion.startsWith("2.12") &&
params.scalaVersion.maybeScalaPatchVersion.exists(_ < 5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal, but version comparison with coursier.core.Version could have worked here, it seems, like

val sv = coursier.core.Version(params.scalaVersion)
if params.scalaVersion.startsWith("2.12.") && sv.compareTo(coursier.core.Version("2.12.15")) < 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants