Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using directives for Markdown inputs #1598

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix using directives for Markdown inputs #1598

merged 2 commits into from
Nov 22, 2022

Conversation

Gedochao
Copy link
Contributor

Fixes #1288

@Gedochao Gedochao marked this pull request as ready for review November 22, 2022 13:01
@Gedochao Gedochao added the bug Something isn't working label Nov 22, 2022
lwronski
lwronski approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 1be0e6d into VirtusLab:main Nov 22, 2022
@Gedochao Gedochao deleted the fix-md-using-directives branch November 22, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

@wleczny wleczny Awaiting requested review from wleczny

Assignees
No one assigned
Labels
bug Something isn't working markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix using directives for multiple Scala snippets in a Markdown file and for plain scala code blocks
2 participants
@Gedochao @lwronski