fix if else in mill.bat #1661
Merged
fix if else in mill.bat #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running mill.bat under windows warning shows up:
'else' is not recognized as an internal or external command, operable program or batch file.
This is because else is in new line, not on the same as ')' ending if
https://github.com/VirtusLab/scala-cli/blob/main/mill.bat#L42
https://stackoverflow.com/questions/12365374/else-is-not-recognized-as-an-internal-or-external-command-operable-program-or
Because of that else is ignored end next if is entered
This causes to in .config/mill-version to take precedence over mill-version in outermost directory, opposite to the intent of the code