-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set page size for aarch64 Linux binaries to 64k #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkurz Thanks a lot for your contribution. I think we can merge it when you get the final confirmation from oracle - #1714 (comment).
@lwronski It's official now! We have green light both from the GraalVM team (oracle/graal#5605 (comment)) and from CI 😉 |
@mkurz Now I'm thinking about page size. Should we use 64k size, maybe 16k will be enough? do you know any system that uses 64k? cc: @alexarchambault |
@lwronski Like said, I am not an expert in this field, just what I read on the internet now. For me it seems most Linux distributions come with 4kb page size kernels, and mine with 16k. It seems 64k is very unusual. It's up to you if you want to use 16k or 64k. If you use 16k, at least you know what the problem could be if someone comes up with a bug report that sounds like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, so let's merge this PR. Thanks for help!
Fixes #1714
Also see discussions here:
PlayNonBlockingInteractionMode
- replace it withbgRun
playframework/playframework#11527 (comment)