Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scripts to latest coursier #1728

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Dec 23, 2022

This is just a reminder for myself.
RC5 is not yet released, but if it is, I hope it contains coursier/coursier#2641 so I am also able to build scala-ci on my Apple Silicon hardware running Linux (I can do that already using locally build cs that works, this just makes it official).

@mkurz mkurz marked this pull request as draft December 23, 2022 15:13
mill Outdated Show resolved Hide resolved
@mkurz mkurz force-pushed the upgrade_coursier branch 2 times, most recently from e1d1623 to 354448c Compare January 4, 2023 16:23
@mkurz mkurz marked this pull request as ready for review January 20, 2023 19:39
@lwronski
Copy link
Contributor

Thanks for the update, it looks like this bug appears also in scala-cli - coursier/coursier#2624.

@lwronski
Copy link
Contributor

Thanks for the update, it looks like this bug appears also in scala-cli - coursier/coursier#2624.

Let's check if it works with static launcher of cs.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mkurz mkurz changed the title Upgrade to coursier 2.1.0-RC5 Upgrade scripts to latest coursier Jun 5, 2023
@mkurz
Copy link
Contributor Author

mkurz commented Jun 5, 2023

@lwronski I rebased this long open PR, can you take a look again?
Thanks!

@mkurz mkurz requested a review from lwronski June 5, 2023 14:18
@lwronski lwronski merged commit 5c7e62c into VirtusLab:main Jun 7, 2023
@mkurz mkurz deleted the upgrade_coursier branch June 7, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants