Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading passwords from commands #1775

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Fix reading passwords from commands #1775

merged 1 commit into from
Feb 28, 2023

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Jan 13, 2023 •
edited
Loading

It seems using sys.process adds superfluous new line characters when reading the command output. Better use ProcessBuilder / Process directly.

@alexarchambault alexarchambault force-pushed the fix-config-password-command branch from b5e2832 to 7ba7ee8 Compare February 23, 2023 15:30
@alexarchambault alexarchambault marked this pull request as ready for review February 23, 2023 16:34
Gedochao
Gedochao reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some sort of anti-regression test for this?
EDIT: and if not, maybe just explain more in some inline comments in the code on why we have to use ProcessBuilder rather than sys.process...

@alexarchambault alexarchambault force-pushed the fix-config-password-command branch from 7ba7ee8 to c5674eb Compare February 27, 2023 13:51
@alexarchambault
Copy link
Contributor Author

alexarchambault commented Feb 27, 2023 •
edited
Loading

EDIT: and if not, maybe just explain more in some inline comments in the code on why we have to use ProcessBuilder rather than sys.process...

Right, I thought I had done that already, but didn't… I just fixed it.

@alexarchambault alexarchambault merged commit 019ff6e into VirtusLab:main Feb 28, 2023
@alexarchambault alexarchambault deleted the fix-config-password-command branch February 28, 2023 08:45
@Gedochao Gedochao added the bug Something isn't working label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexarchambault @Gedochao