-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build/taskStart and taskFinish to the exception reporting BSP mechanism #1821
Merged
MaciejG604
merged 1 commit into
VirtusLab:main
from
MaciejG604:bsp-task-finished-on-error
Feb 9, 2023
Merged
Add build/taskStart and taskFinish to the exception reporting BSP mechanism #1821
MaciejG604
merged 1 commit into
VirtusLab:main
from
MaciejG604:bsp-task-finished-on-error
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
reviewed
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some test to BspTestDefinitions
to check your changes.
Gedochao
reviewed
Feb 2, 2023
MaciejG604
force-pushed
the
bsp-task-finished-on-error
branch
from
February 2, 2023 15:09
1d5b96a
to
67fb675
Compare
MaciejG604
force-pushed
the
bsp-task-finished-on-error
branch
from
February 3, 2023 11:43
67fb675
to
5a02976
Compare
lwronski
reviewed
Feb 3, 2023
MaciejG604
force-pushed
the
bsp-task-finished-on-error
branch
from
February 3, 2023 13:41
5a02976
to
ed9085b
Compare
lwronski
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gedochao
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue with only one $ivy or $dep import error being visible at a time. The behaviour has been checked with metals.