Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/taskStart and taskFinish to the exception reporting BSP mechanism #1821

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Feb 1, 2023

This resolves the issue with only one $ivy or $dep import error being visible at a time. The behaviour has been checked with metals.

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some test to BspTestDefinitions to check your changes.

@MaciejG604 MaciejG604 marked this pull request as ready for review February 3, 2023 08:51
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 self-assigned this Feb 8, 2023
@MaciejG604 MaciejG604 merged commit f64512a into VirtusLab:main Feb 9, 2023
tgodzik pushed a commit to tgodzik/scala-cli that referenced this pull request Feb 13, 2023
@Gedochao Gedochao added bug Something isn't working IDE labels Feb 15, 2023
@MaciejG604 MaciejG604 deleted the bsp-task-finished-on-error branch February 21, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants