Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass user arguments to JS runner #1826

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Pass user arguments to JS runner #1826

merged 1 commit into from
Feb 27, 2023

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault marked this pull request as ready for review February 27, 2023 10:44
Gedochao
Gedochao approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
it could be cool to add some docs for this, but can be done separately

@alexarchambault alexarchambault merged commit e204f2d into VirtusLab:main Feb 27, 2023
@alexarchambault alexarchambault deleted the scala-js-run-args branch February 27, 2023 13:53
@Gedochao Gedochao added the enhancement New feature or request label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexarchambault @Gedochao