-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further document publish command #1914
Merged
MaciejG604
merged 4 commits into
VirtusLab:main
from
MaciejG604:document-publish-options
Mar 21, 2023
Merged
Further document publish command #1914
MaciejG604
merged 4 commits into
VirtusLab:main
from
MaciejG604:document-publish-options
Mar 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
reviewed
Mar 10, 2023
modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
document-publish-options
branch
from
March 10, 2023 08:33
7e0af90
to
28e3a9f
Compare
Gedochao
reviewed
Mar 10, 2023
MaciejG604
force-pushed
the
document-publish-options
branch
2 times, most recently
from
March 10, 2023 14:08
478dc58
to
d70f593
Compare
MaciejG604
force-pushed
the
document-publish-options
branch
2 times, most recently
from
March 14, 2023 12:05
4e3ae4f
to
872819b
Compare
lwronski
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Document signer option, remove fragment about 'config:...' value
MaciejG604
force-pushed
the
document-publish-options
branch
from
March 21, 2023 06:56
872819b
to
7a5efe2
Compare
Gedochao
added
documentation
Improvements or additions to documentation
publish command
labels
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionaly:
--signer none
always takes priority