-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude using directive #2053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
exclude
branch
3 times, most recently
from
April 25, 2023 22:07
4b24ffd
to
b65194c
Compare
MaciejG604
reviewed
Apr 26, 2023
MaciejG604
reviewed
Apr 26, 2023
lwronski
force-pushed
the
exclude
branch
3 times, most recently
from
April 27, 2023 17:18
e833a2e
to
c1f74d4
Compare
romanowski
reviewed
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It generally looks good. There is an issue with documentation generation but not related to this PR.
Also, shouldn't we also provide a command line option to exclude things?
modules/build/src/test/scala/scala/build/tests/SourcesTests.scala
Outdated
Show resolved
Hide resolved
modules/build/src/test/scala/scala/build/tests/SourcesTests.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/scala/build/errors/MultipleExcludeError.scala
Outdated
Show resolved
Hide resolved
modules/directives/src/main/scala/scala/build/preprocessing/directives/Sources.scala
Outdated
Show resolved
Hide resolved
lwronski
force-pushed
the
exclude
branch
5 times, most recently
from
April 28, 2023 14:42
fb8892b
to
d9774c0
Compare
MaciejG604
reviewed
Apr 28, 2023
modules/build/src/test/scala/scala/build/tests/ExcludeTests.scala
Outdated
Show resolved
Hide resolved
lwronski
force-pushed
the
exclude
branch
2 times, most recently
from
April 28, 2023 16:33
5d7c38e
to
5b181cf
Compare
MaciejG604
approved these changes
May 2, 2023
Gedochao
approved these changes
May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.