Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid scala-cli-signing artifact downloads #2054

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix invalid scala-cli-signing artifact downloads #2054

merged 2 commits into from
Apr 27, 2023

Conversation

Gedochao
Copy link
Contributor

Fixes #2036

@Gedochao Gedochao force-pushed the fix-wrong-scala-cli-signing-launcher-download branch from 6fe22a0 to 2ba250a Compare April 25, 2023 06:48
@Gedochao Gedochao added the bug Something isn't working label Apr 25, 2023
@Gedochao
Copy link
Contributor Author

Gedochao commented Apr 25, 2023 •
edited
Loading

it seems the CI won't pass until VirtusLab/scala-cli-signing#33 gets merged...
Fixed, included the scala-cli-signing bump to v0.2.1 here.

@Gedochao Gedochao force-pushed the fix-wrong-scala-cli-signing-launcher-download branch from 2ba250a to d12709f Compare April 25, 2023 11:33
@Gedochao Gedochao force-pushed the fix-wrong-scala-cli-signing-launcher-download branch from d12709f to ff8f7ad Compare April 25, 2023 12:29
@Gedochao Gedochao merged commit e6e2c21 into VirtusLab:main Apr 27, 2023
@Gedochao Gedochao deleted the fix-wrong-scala-cli-signing-launcher-download branch April 27, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Gedochao @lwronski