Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object wrapper flag and directive #2136

Merged

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented May 23, 2023

Addresses #2128 and #2117

Adds cli flag --object-wrapper and using objectWrapper for forcing object-wrapping for script.

Additionally fixes wrong mainClass name being passed for scripts when filename contains special characters e.g. -

@MaciejG604 MaciejG604 force-pushed the add-object-wrapper-flag-and-directive branch from c042666 to e0f1eca Compare May 23, 2023 09:02
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 merged commit 758cf6a into VirtusLab:main May 23, 2023
@Gedochao Gedochao added enhancement New feature or request UX labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants