-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document BuildInfo #2325
Merged
Merged
Document BuildInfo #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
document-build-info
branch
from
August 3, 2023 07:48
65992e9
to
ce02066
Compare
Closed
tgodzik
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments from me, great work!
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
document-build-info
branch
from
August 7, 2023 08:49
ce02066
to
16b7124
Compare
tgodzik
requested changes
Aug 7, 2023
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
document-build-info
branch
from
August 7, 2023 11:41
16b7124
to
95b7af9
Compare
lwronski
reviewed
Aug 7, 2023
MaciejG604
force-pushed
the
document-build-info
branch
from
August 7, 2023 11:59
95b7af9
to
a950789
Compare
lwronski
approved these changes
Aug 7, 2023
tgodzik
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Conflicts: # modules/build/src/test/scala/scala/build/tests/SourceGeneratorTests.scala # modules/options/src/main/scala/scala/build/info/BuildInfo.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for #2249 (#2106)