Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bloop timeouts in tests #2407

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Remove bloop timeouts in tests #2407

merged 1 commit into from
Sep 21, 2023

Conversation

MaciejG604
Copy link
Contributor

I've tested this and it seems to make the tests less flaky on the CI.

lwronski
lwronski approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge these changes. However, I'm uncertain if it will address the issue. By removing the extra options, we back to the default timeout, which is lower than what was set in these options.

@MaciejG604 MaciejG604 merged commit 90fc7c5 into VirtusLab:main Sep 21, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaciejG604 @tgodzik @lwronski