Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load local ivy path from ivy.home and user.home system properties #2484

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

JD557
Copy link
Contributor

@JD557 JD557 commented Oct 22, 2023

Fixes #2483

@Gedochao
Copy link
Contributor

LGTM, thanks for the contribution!
@JD557 would you have the time to add an anti-regression test as well?
We have the relevant integration tests in scala.cli.integration.PublishLocalTestDefinitions:

abstract class PublishLocalTestDefinitions(val scalaVersionOpt: Option[String])

@JD557
Copy link
Contributor Author

JD557 commented Oct 23, 2023

Added some tests in b8d5023.

I hope this is what you meant, I mostly just copied and adapted the other test in that file.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 0e8796e into VirtusLab:main Oct 24, 2023
38 checks passed
@JD557 JD557 deleted the fix-local-path branch October 24, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish local is not respecting user.home
2 participants