Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact & actions/download-artifact from 3 to 4 #2701

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Jan 23, 2024

Supersedes #2640 & #2641, the bump has to be done in one go.
This is just a squashed commit with the contents of both aforementioned PRs.

---
Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@Gedochao
Copy link
Contributor Author

Before merging this, we should pay attention if it won't break our test reports, as dorny/test-reporter seems to still rely on the incompatible actions/download-artifact@v3...

@Gedochao
Copy link
Contributor Author

This indeed seems to break our test reports.
Created a ticket:

@Gedochao Gedochao marked this pull request as draft February 12, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants