Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap scalameta trees for semanticdb-shared & bump scalameta to 4.9.8 #3017

Conversation

Gedochao
Copy link
Contributor

Supersedes #3016

@Gedochao
Copy link
Contributor Author

jline/jline3#954
Ok... so it seems we swallow Jline 3.25.1 along with scalameta 4.9.8 here.
That version of JLine seems to require Graal 23+... so we need to bump Graal first somehow for our native images to get generated properly.
Otherwise we're getting:

Error: Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jline-terminal/native-image.properties'. Use -H:PrintFlags= to list all available options.
Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jline-terminal-jansi/native-image.properties'. Use -H:PrintFlags= to list all available options.
Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jline-terminal-jni/native-image.properties'. Use -H:PrintFlags= to list all available options.
Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jansi/native-image.properties'. Use -H:PrintFlags= to list all available options.
Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jline-terminal-jna/native-image.properties'. Use -H:PrintFlags= to list all available options.
Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jline-terminal-ffm/native-image.properties'. Use -H:PrintFlags= to list all available options.
Could not find option 'UnlockExperimentalVMOptions' from 'jar:file:///data/cp/jline-3.25.1.jar!/META-INF/native-image/org.jline/jline-native/native-image.properties'. Use -H:PrintFlags= to list all available options.

And bumping Graal is tricky, since the aarch64 platform has been dropped from CE after the version we're at.
I'll try looking into it separately, but it seems this is blocked for now.

@Gedochao Gedochao force-pushed the maintenance/scalameta-trees-to-semanticdb-shared branch from 6866de8 to f8b7f20 Compare July 11, 2024 12:57
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this!

project/deps.sc Show resolved Hide resolved
@Gedochao Gedochao merged commit d3af5b5 into VirtusLab:main Jul 11, 2024
75 checks passed
@Gedochao Gedochao deleted the maintenance/scalameta-trees-to-semanticdb-shared branch July 11, 2024 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants