-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc improvements in compiler options handling #3253
Merged
Gedochao
merged 8 commits into
VirtusLab:main
from
Gedochao:maintenance/scalac-options-tweaks
Nov 21, 2024
Merged
Misc improvements in compiler options handling #3253
Gedochao
merged 8 commits into
VirtusLab:main
from
Gedochao:maintenance/scalac-options-tweaks
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5017643
to
63477ba
Compare
fba154a
to
5d88ab1
Compare
Note: the changes are rather large, although I tried to split the commits in a way so that it's easy to review. Let me know if I should split it into smaller bits. |
tgodzik
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
...es/integration/src/test/scala/scala/cli/integration/CompileScalacCompatTestDefinitions.scala
Show resolved
Hide resolved
… sub-command test suite
… favouring `scalac` meaning
- -coverage-exclude-classlikes - -coverage-exclude-files - -Wshadow - -Xlint - -Xplugin-disable - -Xplugin-require - -Yimports - -Yfrom-tasty-ignore-list
…compiler flags without `-O`
a59b94e
to
8e44678
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-minor-release
This change should require a minor version bump.
scalac compatibility
Issues tied with compatibility with the scalac (compiler) command.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a (much belated) follow-up to scala/scala3#19766, which revamped how compiler settings can be called. We haven't been supporting some of the new syntax.
The actual follow-up we plan for is #2867, this PR should be treated as the first step.
Changes include
-
or--
prefixes interchangably (-Wunused:locals
means exactly the same as--Wunused:locals
):
or a space, interchangably (-Wunused:locals
means the same as-Wunused locals
)-Wunused:locals,privates
,-Wunused:locals -Wunusedprivates
and-Wunused locals -Wunused privates
are all synonyms.-O
now don't:-explain
-experimental
-Wunused
-coverage-exclude-classlikes
-coverage-exclude-files
-Wshadow
-Xlint
-Xmacro-settings
-Xplugin-disable
-Xplugin-require
-Yimports
-Yfrom-tasty-ignore-list
--source
(which used to indicate a source jar artifact is to be produced by thepackage
sub-command) and-source
(a compiler option) are now synonyms, as treated by the Scala compiler--src
or--sources
instead.