Fix using directives crashing on */ by removing /* (..) */ comments support in using_directives
#3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/fix-wrong-comments-in-using-directives
branch
from
9189cd8 to
8d3f7bc
Compare
Gedochao
commented
Dec 19, 2024
modules/integration/src/test/scala/scala/cli/integration/CompileTestDefinitions.scala
Outdated
Show resolved
Hide resolved
Gedochao
force-pushed
the
maintenance/fix-wrong-comments-in-using-directives
branch
from
8d3f7bc to
19a7556
Compare
tgodzik
approved these changes
Dec 20, 2024
modules/integration/src/test/scala/scala/cli/integration/CompileTestDefinitions.scala
Outdated
Show resolved
Hide resolved
…ts support in `using_directives` - update `using_directives` to 1.1.4
Gedochao
force-pushed
the
maintenance/fix-wrong-comments-in-using-directives
branch
from
19a7556 to
bb72cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3374
Requires:
/* (...) */comments support using_directives#67