Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: selectively zero match lists #2087

Closed

Conversation

secDre4mer
Copy link
Contributor

Instead of completely zeroing match lists at the end of each scan (which is O(num_strings) and thus scales badly with large rule sets), keep track of which list entries have been used. Only those entries need to be zeroed at the end. This essentially changes the O(num_strings) to O(num_matched_strings), which is usually far lesser.

Instead of completely zeroing match lists at the end of each scan
(which is O(num_strings) and thus scales badly with large rule sets),
keep track of which list entries have been used. Only those entries
need to be zeroed at the end. This essentially changes the
O(num_strings) to O(num_matched_strings), which is usually far lesser.
@secDre4mer secDre4mer marked this pull request as ready for review June 13, 2024 10:19
@secDre4mer
Copy link
Contributor Author

Since this hasn't seen any attention so far: @plusvic do performance improvements like this still have a chance of being merged (since YARA doesn't gain any more features and effort instead goes into yara-x)? If not, I'd like to close this.

@plusvic
Copy link
Member

plusvic commented Nov 18, 2024

Sorry for the delayed response, this fell trough the cracks. As this is a relatively important change, and all my efforts are put now in YARA-X I prefer not merging this PR. So I'm closing it.

@plusvic plusvic closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants