forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[libc++][string] Add regression test for sized new/delete bug (llvm#1…
…10210) This is regression test for llvm#90292. Allocator used in test is very similar to test_allocator. However, reproducer requires size_type of the string to be 64bit, but test_allocator uses 32bit. 32bit size_type makes `sizeof(string::__long)` to be 16, but the alignment issue fixed with llvm#90292 is only triggered with default `sizeof(string::__long)` which is 24. Fixes llvm#92128. --------- Co-authored-by: Louis Dionne <ldionne.2@gmail.com>
- Loading branch information
Showing
1 changed file
with
66 additions
and
0 deletions.
There are no files selected for viewing
66 changes: 66 additions & 0 deletions
66
libcxx/test/std/strings/basic.string/string.capacity/deallocate_size.pass.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
// <string> | ||
|
||
// Make sure the size we allocate and deallocate match. See https://github.com/llvm/llvm-project/pull/90292. | ||
|
||
#include <string> | ||
#include <cassert> | ||
#include <cstdint> | ||
#include <type_traits> | ||
|
||
#include "test_macros.h" | ||
|
||
static int allocated_; | ||
|
||
template <class T, class Sz> | ||
struct test_alloc { | ||
typedef Sz size_type; | ||
typedef typename std::make_signed<Sz>::type difference_type; | ||
typedef T value_type; | ||
typedef value_type* pointer; | ||
typedef const value_type* const_pointer; | ||
typedef typename std::add_lvalue_reference<value_type>::type reference; | ||
typedef typename std::add_lvalue_reference<const value_type>::type const_reference; | ||
|
||
template <class U> | ||
struct rebind { | ||
typedef test_alloc<U, Sz> other; | ||
}; | ||
|
||
TEST_CONSTEXPR_CXX14 pointer allocate(size_type n, const void* = nullptr) { | ||
allocated_ += n; | ||
return std::allocator<value_type>().allocate(n); | ||
} | ||
|
||
TEST_CONSTEXPR_CXX14 void deallocate(pointer p, size_type s) { | ||
allocated_ -= s; | ||
std::allocator<value_type>().deallocate(p, s); | ||
} | ||
}; | ||
|
||
template <class Sz> | ||
void test() { | ||
for (int i = 1; i < 1000; ++i) { | ||
using Str = std::basic_string<char, std::char_traits<char>, test_alloc<char, Sz> >; | ||
{ | ||
Str s(i, 't'); | ||
assert(allocated_ == 0 || allocated_ >= i); | ||
} | ||
} | ||
assert(allocated_ == 0); | ||
} | ||
|
||
int main(int, char**) { | ||
test<uint32_t>(); | ||
test<uint64_t>(); | ||
test<size_t>(); | ||
|
||
return 0; | ||
} |