Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional unit parameter to kinetics #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uliw
Copy link

@uliw uliw commented Dec 8, 2022

It seems that the kinetic method always assumes that the rates returned by the rate_function are in mmol.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #25 (08f44ff) into master (d6f94d8) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files           7        7           
  Lines         698      698           
=======================================
  Hits          527      527           
  Misses        171      171           
Impacted Files Coverage Δ
phreeqpython/solution.py 83.87% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant