Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer should be fixed #42

Closed
johannsell opened this issue Sep 17, 2018 · 2 comments
Closed

Footer should be fixed #42

johannsell opened this issue Sep 17, 2018 · 2 comments
Labels

Comments

@johannsell
Copy link
Member

johannsell commented Sep 17, 2018

If the page content does not use the whole display space, the footer's bottom line should be fixed to the bottom of the display space. Use CSS display: flex; to fix the issue.

@johannsell johannsell added the bug label Sep 17, 2018
@johannsell johannsell added this to the Pool Going Live milestone Sep 17, 2018
@deinelieblings
Copy link
Member

the bug ist fixed by f2d137d

@johannsell
Copy link
Member Author

Don't use position: relative. A modern browser should be able to use

body {
  display: flex;
  flex-direction: column;
  justify-content: space-between;
}

johannsell added a commit that referenced this issue Nov 27, 2018
johannsell added a commit that referenced this issue Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants