-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to the go1.16 #19
Conversation
TheSAS
commented
Jan 4, 2022
•
edited
Loading
edited
- use tools/tools.go for indirect dependencies (fixes go.mod issues)
- go mod tidy
- use go1.16
- regenerate all templates
- Switch to the Github actions
Seems like the travis isn't running on PRs. Maybe switch to github actions, travis has turned useless. Other than that LGTM. |
I'll take a look at what happened to Travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do a go mod tidy
to clean up a bit ? Looks like we could slim down the sum file :-)
Already did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actions should be able to run on this PR. Added some change suggestions.
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
… into update-build-version-go116
GitHub actions are not working to Forked repos, which is kinda expected. So i have created a new PR #20
|
@TheSAS Seems the PR can now be tested. |
Fixing issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM