Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to the go1.16 #19

Merged
merged 15 commits into from
Jan 25, 2022
Merged

Bump to the go1.16 #19

merged 15 commits into from
Jan 25, 2022

Conversation

TheSAS
Copy link
Contributor

@TheSAS TheSAS commented Jan 4, 2022

  • use tools/tools.go for indirect dependencies (fixes go.mod issues)
  • go mod tidy
  • use go1.16
  • regenerate all templates
  • Switch to the Github actions

@klauspost
Copy link
Contributor

Seems like the travis isn't running on PRs. Maybe switch to github actions, travis has turned useless. Other than that LGTM.

@TheSAS
Copy link
Contributor Author

TheSAS commented Jan 4, 2022

I'll take a look at what happened to Travis.

Copy link
Contributor

@eikmadsen eikmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a go mod tidy to clean up a bit ? Looks like we could slim down the sum file :-)

@TheSAS
Copy link
Contributor Author

TheSAS commented Jan 4, 2022

Already did go mod tidy, it is the latest result generated by it.

@TheSAS TheSAS requested a review from eikmadsen January 4, 2022 12:37
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions should be able to run on this PR. Added some change suggestions.

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
go.sum Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TheSAS and others added 7 commits January 4, 2022 15:11
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
@TheSAS
Copy link
Contributor Author

TheSAS commented Jan 4, 2022

GitHub actions are not working to Forked repos, which is kinda expected. So i have created a new PR #20

Closing this PR in favor of a new one.

@TheSAS TheSAS closed this Jan 4, 2022
@klauspost
Copy link
Contributor

@TheSAS Seems the PR can now be tested.

@TheSAS TheSAS reopened this Jan 4, 2022
@TheSAS
Copy link
Contributor Author

TheSAS commented Jan 4, 2022

Fixing issues

Copy link
Contributor

@eikmadsen eikmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheSAS TheSAS merged commit 1a1ec38 into Vivino:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants