Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIRH-96] adds backlink to project site #75

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

agnlez
Copy link
Member

@agnlez agnlez commented Jul 29, 2024

Substitute this line for a meaningful title for your changes

Overview

image

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

https://vizzuality.atlassian.net/browse/SIRH-96

@agnlez agnlez requested a review from alexeh July 29, 2024 14:08
@agnlez agnlez self-assigned this Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4-growth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 9:14am

Copy link
Collaborator

@alexeh alexeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this without a simple test because:

  1. I like you
  2. This goes to main and there is no yet a proper testing scaffold there and it would be an overhead to apply it
  3. You gonna add a basic test as soons as you rebase this to develop.

Also, remember to bump the project and tag a version in the repo!!

@agnlez agnlez merged commit 26701e2 into main Aug 5, 2024
3 checks passed
@agnlez agnlez deleted the SIRH-96-add-backlink-to-4-growth branch August 5, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants