Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttdl done marks all tasks as done #92

Closed
arthurbdev opened this issue Feb 28, 2024 · 2 comments
Closed

ttdl done marks all tasks as done #92

arthurbdev opened this issue Feb 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@arthurbdev
Copy link

arthurbdev commented Feb 28, 2024

I don't know if it's intended behaviour but ttdl done without any arguments marks all tasks as done.

Edit: Just tested it out, ttdl rm without any arguments wipes out all the undone tasks.
I think there needs to be a check if any arguments are provided before processing the command.

@VladimirMarkelov VladimirMarkelov added the bug Something isn't working label Feb 29, 2024
@VladimirMarkelov
Copy link
Owner

Thank you for the report. It was by design but it was not intended: all commands share the same task ID list processing without exceptions. In my opinion, no argument makes sense only for ls command. The rest commands must require a filter from a user. Otherwise, it is easy to ruin a todo list by running edit or rm for all tasks.

@VladimirMarkelov
Copy link
Owner

Now a few commands are forbidden to run without specifying tasks to process.

Version 4.2.1 published on crates.io. Releases updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants