Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Tests Coverage #194

Merged
merged 9 commits into from
Jul 12, 2023
Merged

Increase Tests Coverage #194

merged 9 commits into from
Jul 12, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Jul 11, 2023

Resolves #187

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +17.10 🎉

Comparison is base (77ecaea) 81.06% compared to head (179e45e) 98.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #194       +/-   ##
===========================================
+ Coverage   81.06%   98.17%   +17.10%     
===========================================
  Files          27       23        -4     
  Lines         243      219       -24     
  Branches       32       29        -3     
===========================================
+ Hits          197      215       +18     
+ Misses         43        3       -40     
+ Partials        3        1        -2     
Impacted Files Coverage Δ
src/components/TextPanel/TextPanel.tsx 100.00% <ø> (+13.33%) ⬆️
src/constants/default.ts 100.00% <ø> (ø)
src/constants/tests.ts 100.00% <ø> (ø)
src/components/CustomEditor/CustomEditor.tsx 100.00% <100.00%> (ø)
src/components/CustomEditor/index.ts 100.00% <100.00%> (ø)
src/components/index.ts 100.00% <100.00%> (ø)
src/constants/editor.ts 100.00% <100.00%> (ø)
src/helpers/variable.ts 100.00% <100.00%> (+88.00%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asimonok asimonok self-assigned this Jul 11, 2023
@asimonok asimonok requested a review from mikhail-vl July 11, 2023 09:51
@asimonok asimonok changed the title Add tests for replaceVariablesHelper Increase Tests Coverage Jul 11, 2023
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 12, 2023
@mikhail-vl mikhail-vl added this to the Version 4.1.0 milestone Jul 12, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit d4ddfa5 into main Jul 12, 2023
@mikhail-vl mikhail-vl deleted the feat/increase-tests-coverage branch July 12, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Test Coverage
2 participants