Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variableValue helper and re-render on dashboard refresh #252

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

asimonok
Copy link
Collaborator

Due to variable helper limitation (works only if variable format is not specified). Was added variableValue helper to use replaced variable value.

Example of usage:

<a href="http://localhost?{{variableValue '${slug:queryparam}'}}">Link</a>

@asimonok asimonok self-assigned this Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e651bfb) 98.97% compared to head (26c61d2) 98.74%.

Files Patch % Lines
src/components/TextPanel/TextPanel.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   98.97%   98.74%   -0.23%     
==========================================
  Files          34       34              
  Lines         389      399      +10     
  Branches       50       50              
==========================================
+ Hits          385      394       +9     
- Misses          3        4       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 25, 2023
@mikhail-vl mikhail-vl added this to the Version 4.3.0 milestone Dec 25, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit a1a159d into main Dec 25, 2023
4 of 6 checks passed
@mikhail-vl mikhail-vl deleted the feat/variable-helpers branch December 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants