Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Info message if sanitize enabled #290

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Mar 12, 2024

Resolves: #289

Current Implementation:

image

@vitPinchuk vitPinchuk requested a review from asimonok March 12, 2024 15:46
@vitPinchuk vitPinchuk self-assigned this Mar 12, 2024
@vitPinchuk vitPinchuk marked this pull request as draft March 12, 2024 15:48
@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 13, 2024
@mikhail-vl mikhail-vl added this to the Version 4.5.0 milestone Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (9deb5ff) to head (2738b16).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          35       35           
  Lines         447      447           
  Branches       68       69    +1     
=======================================
  Hits          442      442           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk marked this pull request as ready for review March 13, 2024 07:35
@vitPinchuk
Copy link
Contributor Author

@asimonok
Ready for review

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@asimonok asimonok requested a review from mikhail-vl March 13, 2024 14:07
@mikhail-vl mikhail-vl merged commit d9b5715 into main Mar 14, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/external-resource-updated branch March 14, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show external resource unavailable if sanitize enabled
3 participants