Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expandable Editors #348

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Add Expandable Editors #348

merged 9 commits into from
Aug 22, 2024

Conversation

mikhail-vl
Copy link
Member

@mikhail-vl mikhail-vl commented Aug 21, 2024

@vitPinchuk Please update to make height dynamic, around 80% similar to width.

Is it possible to open universal editor with multiple tabs, depends which one is selected?

  • Content
  • Default Content
  • Before Render
  • After Render
  • Styles

Like in the https://developers.grafana.com/ui/latest/index.html?path=/story/overlays-modal--with-tabs

Screenshot 2024-08-21 at 3 12 03 PM

We can do it in the upcoming release. Also, same concept applicable for Business Forms.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 21, 2024
@mikhail-vl mikhail-vl added this to the Text 5.2.0 milestone Aug 21, 2024
@mikhail-vl mikhail-vl self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (d4b8830) to head (de8d4e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          41       41           
  Lines         584      586    +2     
  Branches       91       92    +1     
=======================================
+ Hits          576      578    +2     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk
Copy link
Contributor

@mikhail-vl looks good.

But I added changes as discussed, for code editor version 2.8.1
We need to publish PR 56 first and then update @volkovlabs/components to 2.8.1 in branch

Copy link
Member Author

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 583faa4 into main Aug 22, 2024
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-editor branch August 22, 2024 14:40
@mikhail-vl mikhail-vl modified the milestones: Text 5.2.0, Text 5.3.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants