-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Expandable Editors #348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 41 41
Lines 584 586 +2
Branches 91 92 +1
=======================================
+ Hits 576 578 +2
Misses 8 8 ☔ View full report in Codecov by Sentry. |
@mikhail-vl looks good. But I added changes as discussed, for code editor version 2.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@vitPinchuk Please update to make height dynamic, around 80% similar to width.
Is it possible to open universal editor with multiple tabs, depends which one is selected?
Like in the https://developers.grafana.com/ui/latest/index.html?path=/story/overlays-modal--with-tabs
We can do it in the upcoming release. Also, same concept applicable for Business Forms.