Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_common.py: Remove some code duplication #490

Merged
merged 45 commits into from
Jul 22, 2024
Merged

_common.py: Remove some code duplication #490

merged 45 commits into from
Jul 22, 2024

Conversation

martingalvan-volue
Copy link
Contributor

No description provided.

@martingalvan-volue martingalvan-volue self-assigned this Jul 16, 2024
@martingalvan-volue martingalvan-volue marked this pull request as ready for review July 16, 2024 13:37
@martingalvan-volue martingalvan-volue marked this pull request as draft July 16, 2024 13:37
@martingalvan-volue martingalvan-volue marked this pull request as ready for review July 16, 2024 13:52
@martingalvan-volue martingalvan-volue changed the title [Draft] _common.py: Remove some code duplication _common.py: Remove some code duplication Jul 17, 2024
@martingalvan-volue martingalvan-volue changed the title _common.py: Remove some code duplication [Draft] _common.py: Remove some code duplication Jul 17, 2024
@martingalvan-volue martingalvan-volue marked this pull request as draft July 17, 2024 08:15
Base automatically changed from grpc_timeseries to master July 17, 2024 14:01
@martingalvan-volue martingalvan-volue changed the title [Draft] _common.py: Remove some code duplication _common.py: Remove some code duplication Jul 17, 2024
@martingalvan-volue martingalvan-volue marked this pull request as ready for review July 17, 2024 14:15
tnoczyns-volue
tnoczyns-volue approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tnoczyns-volue tnoczyns-volue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@martingalvan-volue martingalvan-volue merged commit 5b23b90 into master Jul 22, 2024
9 checks passed
@martingalvan-volue martingalvan-volue deleted the 2_fix_duplicated_code branch July 22, 2024 11:09
@erny-powel erny-powel added this to the Version 1.9 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnoczyns-volue tnoczyns-volue tnoczyns-volue approved these changes

Assignees

@martingalvan-volue martingalvan-volue

Labels
None yet
Projects
None yet
Milestone
Version 1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@martingalvan-volue @tnoczyns-volue @erny-powel