Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve v2 resolution issue in Pigeon go.mod #2136

Closed
byte-bandit opened this issue Sep 6, 2024 · 2 comments
Closed

Resolve v2 resolution issue in Pigeon go.mod #2136

byte-bandit opened this issue Sep 6, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@byte-bandit
Copy link

byte-bandit commented Sep 6, 2024

We can no longer reference Paloma versions directly from Pigeon since we upgraded to a version higher than 1 due to the go mod versioning system. We will need to add a /v2 suffix to our Paloma go.mod, but I forgot to do this for 2.2.0.

@byte-bandit byte-bandit self-assigned this Sep 6, 2024
@taariq
Copy link
Member

taariq commented Sep 11, 2024

@byte-bandit this going into the next release?

@byte-bandit byte-bandit added this to the next milestone Sep 12, 2024
@taariq
Copy link
Member

taariq commented Sep 30, 2024

@maharifu you okay to take over this one?

maharifu added a commit to palomachain/paloma that referenced this issue Oct 1, 2024
# Related Github tickets

- VolumeFi#2136

# Background

From v2 onwards, go forces us to either:
- create a new directory for every version and maintain all versions
within the codebase
- append the version to the module name

We opted for the latter since we don't want to support multiple paloma
versions.

# Testing completed

- [ ] test coverage exists or has been added/updated
- [ ] tested in a private testnet

# Breaking changes

- [ ] I have checked my code for breaking changes
- [ ] If there are breaking changes, there is a supporting migration.
@maharifu maharifu closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants