Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create material utils to clone off of for cleaner setup #670

Merged
merged 5 commits into from
May 22, 2024

Conversation

hanbollar
Copy link
Contributor

@hanbollar hanbollar commented May 18, 2024

Linking

related to #669

Problem

reduce number of overall programs and materials being used in a scene (reduce number of draw calls per renderpass)

Solution

temporary pass to reduce number of overall unique new materials - going to do a cleaner/bigger version of this when we add in a MaterialsManager to actually cache re-used materials better.

Breaking Change

nope

Notes

...


Required to Merge

  • PASS - all necessary actions must pass (excluding the auto-skipped ones)
  • TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
    - [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.
  • TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
    - [ ] BREAKING CHANGE
    • DOCUMENTATION: This includes any changes to html tags and their components
      • make a pr in the documentation repo that updates the manual docs to match the breaking change
      • link the pr of the documentation repo here: #pr
      • that pr must be approved by @lobau
    • SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
      • make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
      • link the pr of the landing page repo here: #pr
      • that pr must be approved by @hanbollar

hanbollar added 5 commits May 16, 2024 19:27
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Copy link

render bot commented May 18, 2024

@hanbollar hanbollar changed the base branch from main to sub-main May 20, 2024 17:59
@hanbollar hanbollar merged commit 4303824 into sub-main May 22, 2024
6 checks passed
@hanbollar hanbollar deleted the hb-materials-utils branch May 22, 2024 21:29
@hanbollar
Copy link
Contributor Author

small - so merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant