Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code examples for External Accounts API #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aloks98
Copy link

@aloks98 aloks98 commented Oct 30, 2020

Added various cURL examples for External accounts API

@aloks98
Copy link
Author

aloks98 commented Oct 30, 2020

@lukeocodes Can you review the changes please? :)

Copy link
Contributor

@lukeocodes lukeocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I don't have time to test it all. I'll add Tony as a reviewer, but add hacktoberfest-accepted in the meantime.

Thank you so much your for contributions <3

@aloks98
Copy link
Author

aloks98 commented Oct 30, 2020

Sure! Let me know if any changes need :D

@tbedford
Copy link
Contributor

tbedford commented Nov 2, 2020

@aloks98 Thanks for your contribution. I will get to at some point but I will need to create the specs for these first. I assume you have tested? (I will also have to set things up and test).

In the mean time a couple of suggestions:

  • Would possibly be better in a top directory of external-accounts - for example: external-accounts/link-application-to-account.sh, as not really related to Accounts (more Messages API).
  • Rename account/external-accounts-api/messenger/delete-a-messenger-accoun.sh to external-accounts/delete-a-messenger-account.sh (notice adds missing t on end of accoun).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants