fix: [breaking] make StartTime nullable on Answered webhook (#568)

* fix: [breaking] make StartTime nullable on Answered webhook * refactor: update test content
Vonage · Mar 13, 2024 · 426d91f · 426d91f
1 parent 8948ead
commit 426d91f
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 4 deletions.
diff --git a/Vonage.Test/Data/Webhooks/ShouldDeserializedAnswered_GivenStartTimeIsNull.json b/Vonage.Test/Data/Webhooks/ShouldDeserializedAnswered_GivenStartTimeIsNull.json
@@ -0,0 +1,15 @@
+{
+  "start_time": null,
+  "headers": {
+    "[redacted]": "[redacted]"
+  },
+  "rate": null,
+  "from": "[redacted]",
+  "to": "[redacted]",
+  "uuid": "c8061992c89a65e3790bfa0aaca6f069",
+  "conversation_uuid": "CON-5a0cdebb-0f35-45a4-9b38-a99f9d12d6d7",
+  "status": "answered",
+  "direction": "inbound",
+  "network": null,
+  "timestamp": "2024-01-25T12:16:32.319Z"
+}
diff --git a/Vonage.Test/Vonage.Test.csproj b/Vonage.Test/Vonage.Test.csproj
@@ -1104,6 +1104,9 @@
         <None Update="VerifyV2\StartVerification\Data\ShouldSerializeSmsWorkflowWithOptionalValues-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
+        <None Update="Data\Webhooks\ShouldDeserializedAnswered_GivenStartTimeIsNull.json">
+            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+        </None>
     </ItemGroup>
     <Target Name="PreBuild" BeforeTargets="PreBuildEvent">
         <Exec Command="node ../.scripts/init.js"/>

diff --git a/Vonage.Test/WebhookStructsTest.cs b/Vonage.Test/WebhookStructsTest.cs
@@ -1,5 +1,7 @@
 using System;
 using System.Globalization;
+using System.IO;
+using FluentAssertions;
 using Newtonsoft.Json;
 using Vonage.Voice.AnswerWebhooks;
 using Vonage.Voice.EventWebhooks;
@@ -384,6 +386,15 @@ public void TestTransfer()
         Assert.Equal("aaaaaaaa-bbbb-cccc-dddd-0123456789ab", transferWebhook.Uuid);
     }
 
+    [Fact]
+    public void ShouldDeserializedAnswered_GivenStartTimeIsNull()
+    {
+        var deserializedEvent =
+            (Answered) EventBase.ParseEvent(
+                File.ReadAllText("Data/Webhooks/ShouldDeserializedAnswered_GivenStartTimeIsNull.json"));
+        deserializedEvent.StartTime.Should().BeNull();
+    }
+
     public class Foo
     {
         public string bar { get; set; }

diff --git a/Vonage/Voice/EventWebhooks/Answered.cs b/Vonage/Voice/EventWebhooks/Answered.cs
@@ -1,5 +1,5 @@
-using Newtonsoft.Json;
-using System;
+using System;
+using Newtonsoft.Json;
 
 namespace Vonage.Voice.EventWebhooks;
 
@@ -9,14 +9,14 @@ public class Answered : CallStatusEvent
     /// call start time
     /// </summary>
     [JsonProperty("start_time")]
-    public DateTime StartTime { get; set; }
+    public DateTime? StartTime { get; set; }
 
     /// <summary>
     /// cost rate for the call
     /// </summary>
     [JsonProperty("rate")]
     public string Rate { get; set; }
-        
+
     /// <summary>
     /// Network the call came from
     /// </summary>