refactor: clean CreateMember tests

Vonage · Jun 4, 2024 · 5b75177 · 5b75177
1 parent 271bfcc
commit 5b75177
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 19 deletions.
diff --git a/Vonage.Test/Conversations/CreateMember/E2ETest.cs b/Vonage.Test/Conversations/CreateMember/E2ETest.cs
@@ -20,6 +20,38 @@ public E2ETest() : base(typeof(E2ETest).Namespace)
         this.CreateConversationAsync(this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializeApp)),
             SerializationTest.BuildAppRequest());
 
+    [Fact]
+    public Task CreateMember_WithMessenger() =>
+        this.CreateConversationAsync(
+            this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializeMessenger)),
+            SerializationTest.BuildMessengerRequest());
+
+    [Fact]
+    public Task CreateMember_WithMms() =>
+        this.CreateConversationAsync(this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializeMms)),
+            SerializationTest.BuildMmsRequest());
+
+    [Fact]
+    public Task CreateMember_WithPhone() =>
+        this.CreateConversationAsync(this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializePhone)),
+            SerializationTest.BuildPhoneRequest());
+
+    [Fact]
+    public Task CreateMember_WithSms() =>
+        this.CreateConversationAsync(this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializeSms)),
+            SerializationTest.BuildSmsRequest());
+
+    [Fact]
+    public Task CreateMember_WithViber() =>
+        this.CreateConversationAsync(this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializeViber)),
+            SerializationTest.BuildViberRequest());
+
+    [Fact]
+    public Task CreateMember_WithWhatsApp() =>
+        this.CreateConversationAsync(
+            this.Serialization.GetRequestJson(nameof(SerializationTest.ShouldSerializeWhatsApp)),
+            SerializationTest.BuildWhatsAppRequest());
+
     private async Task CreateConversationAsync(string jsonRequest, Result<CreateMemberRequest> request)
     {
         this.Helper.Server.Given(WireMock.RequestBuilders.Request.Create()

diff --git a/Vonage.Test/Conversations/CreateMember/SerializationTest.cs b/Vonage.Test/Conversations/CreateMember/SerializationTest.cs
@@ -92,73 +92,91 @@ internal static void VerifyResponse(Member response)
 
     [Fact]
     public void ShouldSerializePhone() =>
+        BuildPhoneRequest()
+            .GetStringContent()
+            .Should()
+            .BeSuccess(this.helper.GetRequestJson());
+
+    internal static Result<CreateMemberRequest> BuildPhoneRequest() =>
         CreateMemberRequest.Build()
             .WithConversationId(ValidConversationId)
             .WithState(ValidState)
             .WithUser(ValidUser)
             .WithPhone(ValidNumber, ChannelType.App, ChannelType.Phone, ChannelType.Sms)
-            .Create()
+            .Create();
+
+    [Fact]
+    public void ShouldSerializeSms() =>
+        BuildSmsRequest()
             .GetStringContent()
             .Should()
             .BeSuccess(this.helper.GetRequestJson());
 
-    [Fact]
-    public void ShouldSerializeSms() =>
+    internal static Result<CreateMemberRequest> BuildSmsRequest() =>
         CreateMemberRequest.Build()
             .WithConversationId(ValidConversationId)
             .WithState(ValidState)
             .WithUser(ValidUser)
             .WithSms(ValidNumber, ChannelType.App, ChannelType.Phone, ChannelType.Sms)
-            .Create()
+            .Create();
+
+    [Fact]
+    public void ShouldSerializeMms() =>
+        BuildMmsRequest()
             .GetStringContent()
             .Should()
             .BeSuccess(this.helper.GetRequestJson());
 
-    [Fact]
-    public void ShouldSerializeMms() =>
+    internal static Result<CreateMemberRequest> BuildMmsRequest() =>
         CreateMemberRequest.Build()
             .WithConversationId(ValidConversationId)
             .WithState(ValidState)
             .WithUser(ValidUser)
             .WithMms(ValidNumber, ChannelType.App, ChannelType.Phone, ChannelType.Sms)
-            .Create()
+            .Create();
+
+    [Fact]
+    public void ShouldSerializeWhatsApp() =>
+        BuildWhatsAppRequest()
             .GetStringContent()
             .Should()
             .BeSuccess(this.helper.GetRequestJson());
 
-    [Fact]
-    public void ShouldSerializeWhatsApp() =>
+    internal static Result<CreateMemberRequest> BuildWhatsAppRequest() =>
         CreateMemberRequest.Build()
             .WithConversationId(ValidConversationId)
             .WithState(ValidState)
             .WithUser(ValidUser)
             .WithWhatsApp(ValidNumber, ChannelType.App, ChannelType.Phone, ChannelType.Sms)
-            .Create()
+            .Create();
+
+    [Fact]
+    public void ShouldSerializeViber() =>
+        BuildViberRequest()
             .GetStringContent()
             .Should()
             .BeSuccess(this.helper.GetRequestJson());
 
-    [Fact]
-    public void ShouldSerializeViber() =>
+    internal static Result<CreateMemberRequest> BuildViberRequest() =>
         CreateMemberRequest.Build()
             .WithConversationId(ValidConversationId)
             .WithState(ValidState)
             .WithUser(ValidUser)
             .WithViber(ValidId, ChannelType.App, ChannelType.Phone, ChannelType.Sms)
-            .Create()
+            .Create();
+
+    [Fact]
+    public void ShouldSerializeMessenger() =>
+        BuildMessengerRequest()
             .GetStringContent()
             .Should()
             .BeSuccess(this.helper.GetRequestJson());
 
-    [Fact]
-    public void ShouldSerializeMessenger() =>
+    internal static Result<CreateMemberRequest> BuildMessengerRequest() =>
         CreateMemberRequest.Build()
             .WithConversationId(ValidConversationId)
             .WithState(ValidState)
             .WithUser(ValidUser)
             .WithMessenger(ValidId, ChannelType.App, ChannelType.Phone, ChannelType.Sms)
-            .Create()
-            .GetStringContent()
-            .Should()
-            .BeSuccess(this.helper.GetRequestJson());
+            .Create();
 }