fix: remove default resolution when creating an archive

Vonage · Feb 26, 2024 · 6570363 · 6570363
1 parent dad79a5
commit 6570363
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 18 deletions.
diff --git a/Vonage.Test/Video/Archives/CreateArchive/Data/ShouldSerializeDefault-request.json b/Vonage.Test/Video/Archives/CreateArchive/Data/ShouldSerializeDefault-request.json
@@ -3,6 +3,5 @@
   "hasAudio": true,
   "hasVideo": true,
   "outputMode": "composed",
-  "resolution": "640x480",
   "streamMode": "auto"
 }
diff --git a/Vonage.Test/Video/Archives/CreateArchive/RequestBuilderTest.cs b/Vonage.Test/Video/Archives/CreateArchive/RequestBuilderTest.cs
@@ -138,7 +138,7 @@ public void Build_ShouldReturnSuccess_WithDefaultValues() =>
                 request.HasVideo.Should().BeTrue();
                 request.Name.Should().BeNone();
                 request.OutputMode.Should().Be(OutputMode.Composed);
-                request.Resolution.Should().Be(RenderResolution.StandardDefinitionLandscape);
+                request.Resolution.Should().BeNone();
                 request.StreamMode.Should().Be(StreamMode.Auto);
                 request.Layout.Should().Be(default(Layout));
             });

diff --git a/Vonage/Common/JsonSerializer.cs b/Vonage/Common/JsonSerializer.cs
@@ -5,6 +5,7 @@
 using Vonage.Common.Failures;
 using Vonage.Common.Monads;
 using Vonage.Common.Serialization;
+using Vonage.Server;
 
 namespace Vonage.Common;
 
@@ -29,6 +30,7 @@ public JsonSerializer()
         this.settings.Converters.Add(new ColorJsonConverter());
         this.settings.Converters.Add(new PhoneNumberJsonConverter());
         this.settings.Converters.Add(new EmailJsonConverter());
+        this.settings.Converters.Add(new EnumDescriptionJsonConverter<RenderResolution>());
     }
 
     /// <summary>

diff --git a/Vonage/Video/Archives/CreateArchive/CreateArchiveRequest.cs b/Vonage/Video/Archives/CreateArchive/CreateArchiveRequest.cs
@@ -63,7 +63,9 @@ namespace Vonage.Video.Archives.CreateArchive;
     ///     outputMode property to "individual", the call to the REST method results in an error.
     /// </summary>
     [JsonPropertyOrder(6)]
-    public RenderResolution Resolution { get; internal init; }
+    [JsonConverter(typeof(MaybeJsonConverter<RenderResolution>))]
+    [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)]
+    public Maybe<RenderResolution> Resolution { get; internal init; }
 
     /// <inheritdoc />
     [JsonPropertyOrder(0)]

diff --git a/Vonage/Video/Archives/CreateArchive/CreateArchiveRequestBuilder.cs b/Vonage/Video/Archives/CreateArchive/CreateArchiveRequestBuilder.cs
@@ -8,15 +8,22 @@ namespace Vonage.Video.Archives.CreateArchive;
 
 internal class CreateArchiveRequestBuilder : IBuilderForSessionId, IBuilderForApplicationId, IBuilderForOptional
 {
+    private Guid applicationId;
     private bool hasAudio = true;
     private bool hasVideo = true;
-    private Guid applicationId;
     private Layout layout;
-    private Maybe<string> name = Maybe<string>.None;
+    private Maybe<string> name;
     private OutputMode outputMode = OutputMode.Composed;
-    private RenderResolution resolution = RenderResolution.StandardDefinitionLandscape;
-    private StreamMode streamMode = StreamMode.Auto;
+    private Maybe<RenderResolution> resolution;
     private string sessionId;
+    private StreamMode streamMode = StreamMode.Auto;
+
+    /// <inheritdoc />
+    public IBuilderForSessionId WithApplicationId(Guid value)
+    {
+        this.applicationId = value;
+        return this;
+    }
 
     /// <inheritdoc />
     public Result<CreateArchiveRequest> Create() =>
@@ -49,13 +56,6 @@ public IBuilderForOptional DisableVideo()
         return this;
     }
 
-    /// <inheritdoc />
-    public IBuilderForSessionId WithApplicationId(Guid value)
-    {
-        this.applicationId = value;
-        return this;
-    }
-
     /// <inheritdoc />
     public IBuilderForOptional WithArchiveLayout(Layout value)
     {
@@ -85,16 +85,16 @@ public IBuilderForOptional WithRenderResolution(RenderResolution value)
     }
 
     /// <inheritdoc />
-    public IBuilderForOptional WithSessionId(string value)
+    public IBuilderForOptional WithStreamMode(StreamMode value)
     {
-        this.sessionId = value;
+        this.streamMode = value;
         return this;
     }
 
     /// <inheritdoc />
-    public IBuilderForOptional WithStreamMode(StreamMode value)
+    public IBuilderForOptional WithSessionId(string value)
     {
-        this.streamMode = value;
+        this.sessionId = value;
         return this;
     }