refactor: [breaking] remove sync methods from VoiceClient

Vonage · Mar 14, 2024 · 70428e7 · 70428e7
1 parent 36fb4f0
commit 70428e7
Show file tree

Hide file tree

Showing 24 changed files with 83 additions and 789 deletions.
diff --git a/...t/Data/VoiceTests/CreateCall-request.json → ...a/VoiceTests/CreateCallAsync-request.json b/...t/Data/VoiceTests/CreateCall-request.json → ...a/VoiceTests/CreateCallAsync-request.json
diff --git a/.../Data/VoiceTests/CreateCall-response.json → .../VoiceTests/CreateCallAsync-response.json b/.../Data/VoiceTests/CreateCall-response.json → .../VoiceTests/CreateCallAsync-response.json
diff --git a/...eateCallWithRandomFromNumber-request.json → ...allAsyncWithRandomFromNumber-request.json b/...eateCallWithRandomFromNumber-request.json → ...allAsyncWithRandomFromNumber-request.json
diff --git a/...ateCallWithRandomFromNumber-response.json → ...llAsyncWithRandomFromNumber-response.json b/...ateCallWithRandomFromNumber-response.json → ...llAsyncWithRandomFromNumber-response.json
diff --git a/Vonage.Test/Data/VoiceTests/CreateCallWithStringParameters-request.json b/Vonage.Test/Data/VoiceTests/CreateCallWithStringParameters-request.json
diff --git a/Vonage.Test/Data/VoiceTests/CreateCallWithStringParameters-response.json b/Vonage.Test/Data/VoiceTests/CreateCallWithStringParameters-response.json
diff --git a/...reateCallWithEndpointAndNcco-request.json → ...allWithStringParametersAsync-request.json b/...reateCallWithEndpointAndNcco-request.json → ...allWithStringParametersAsync-request.json
diff --git a/...eateCallWithEndpointAndNcco-response.json → ...llWithStringParametersAsync-response.json b/...eateCallWithEndpointAndNcco-response.json → ...llWithStringParametersAsync-response.json
diff --git a/.../VoiceTests/GetSpecificCall-response.json → ...eTests/GetSpecificCallAsync-response.json b/.../VoiceTests/GetSpecificCall-response.json → ...eTests/GetSpecificCallAsync-response.json
diff --git a/...t/Data/VoiceTests/ListCalls-response.json → ...a/VoiceTests/ListCallsAsync-response.json b/...t/Data/VoiceTests/ListCalls-response.json → ...a/VoiceTests/ListCallsAsync-response.json
diff --git a/...st/Data/VoiceTests/StartDtmf-request.json → ...ta/VoiceTests/StartDtmfAsync-request.json b/...st/Data/VoiceTests/StartDtmf-request.json → ...ta/VoiceTests/StartDtmfAsync-request.json
diff --git a/...t/Data/VoiceTests/StartDtmf-response.json → ...a/VoiceTests/StartDtmfAsync-response.json b/...t/Data/VoiceTests/StartDtmf-response.json → ...a/VoiceTests/StartDtmfAsync-response.json
diff --git a/.../Data/VoiceTests/StartStream-request.json → .../VoiceTests/StartStreamAsync-request.json b/.../Data/VoiceTests/StartStream-request.json → .../VoiceTests/StartStreamAsync-request.json
diff --git a/...Data/VoiceTests/StartStream-response.json → ...VoiceTests/StartStreamAsync-response.json b/...Data/VoiceTests/StartStream-response.json → ...VoiceTests/StartStreamAsync-response.json
diff --git a/...s/StartStreamWithCredentials-request.json → ...rtStreamAsyncWithCredentials-request.json b/...s/StartStreamWithCredentials-request.json → ...rtStreamAsyncWithCredentials-request.json
diff --git a/...st/Data/VoiceTests/StartTalk-request.json → ...ta/VoiceTests/StartTalkAsync-request.json b/...st/Data/VoiceTests/StartTalk-request.json → ...ta/VoiceTests/StartTalkAsync-request.json
diff --git a/...t/Data/VoiceTests/StartTalk-response.json → ...a/VoiceTests/StartTalkAsync-response.json b/...t/Data/VoiceTests/StartTalk-response.json → ...a/VoiceTests/StartTalkAsync-response.json
diff --git a/...sts/StartTalkWithCredentials-request.json → ...tartTalkAsyncWithCredentials-request.json b/...sts/StartTalkWithCredentials-request.json → ...tartTalkAsyncWithCredentials-request.json
diff --git a/.../Data/VoiceTests/StopStream-response.json → .../VoiceTests/StopStreamAsync-response.json b/.../Data/VoiceTests/StopStream-response.json → .../VoiceTests/StopStreamAsync-response.json
diff --git a/...st/Data/VoiceTests/StopTalk-response.json → ...ta/VoiceTests/StopTalkAsync-response.json b/...st/Data/VoiceTests/StopTalk-response.json → ...ta/VoiceTests/StopTalkAsync-response.json
diff --git a/Vonage.Test/VoiceTests.cs b/Vonage.Test/VoiceTests.cs
diff --git a/Vonage.Test/Vonage.Test.csproj b/Vonage.Test/Vonage.Test.csproj
@@ -164,7 +164,7 @@
         <None Update="Data\NumberInsightsTests\AdvancedNIRequestSyncWithNotRoamingStatus-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\CreateCall-request.json">
+        <None Update="Data\VoiceTests\CreateCallAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="Data\RedactTests\RedactReturns429-response.json">
@@ -687,13 +687,7 @@
         <None Update="Data\NccoTests\TestConnectWithAdvancedMachineDetection-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\CreateCall-response.json">
-            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-        </None>
-        <None Update="Data\VoiceTests\CreateCallWithEndpointAndNcco-response.json">
-            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-        </None>
-        <None Update="Data\VoiceTests\CreateCallWithEndpointAndNcco-request.json">
+        <None Update="Data\VoiceTests\CreateCallAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="Data\VoiceTests\CreateCallWithUnicodeCharacters-request.json">
@@ -702,28 +696,28 @@
         <None Update="Data\VoiceTests\CreateCallWithUnicodeCharacters-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\CreateCallWithStringParameters-response.json">
+        <None Update="Data\VoiceTests\CreateCallWithStringParametersAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\CreateCallWithStringParameters-request.json">
+        <None Update="Data\VoiceTests\CreateCallWithStringParametersAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StopStream-response.json">
+        <None Update="Data\VoiceTests\StopStreamAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StopTalk-response.json">
+        <None Update="Data\VoiceTests\StopTalkAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\CreateCallWithRandomFromNumber-request.json">
+        <None Update="Data\VoiceTests\CreateCallAsyncWithRandomFromNumber-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\CreateCallWithRandomFromNumber-response.json">
+        <None Update="Data\VoiceTests\CreateCallAsyncWithRandomFromNumber-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\GetSpecificCall-response.json">
+        <None Update="Data\VoiceTests\GetSpecificCallAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\ListCalls-response.json">
+        <None Update="Data\VoiceTests\ListCallsAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="Data\VoiceTests\UpdateCallWithActionsType-request.json">
@@ -732,19 +726,19 @@
         <None Update="Data\VoiceTests\UpdateCallWithInlineNcco-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartDtmf-response.json">
+        <None Update="Data\VoiceTests\StartDtmfAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartDtmf-request.json">
+        <None Update="Data\VoiceTests\StartDtmfAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartStream-response.json">
+        <None Update="Data\VoiceTests\StartStreamAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartStream-request.json">
+        <None Update="Data\VoiceTests\StartStreamAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartStreamWithCredentials-request.json">
+        <None Update="Data\VoiceTests\StartStreamAsyncWithCredentials-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="Data\VoiceTests\UpdateCallWithCredentials-request.json">
@@ -753,13 +747,13 @@
         <None Update="Data\VoiceTests\UpdateCallAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartTalk-response.json">
+        <None Update="Data\VoiceTests\StartTalkAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartTalk-request.json">
+        <None Update="Data\VoiceTests\StartTalkAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\VoiceTests\StartTalkWithCredentials-request.json">
+        <None Update="Data\VoiceTests\StartTalkAsyncWithCredentials-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="SubAccounts\GetSubAccounts\Data\ShouldDeserialize200-response.json">

diff --git a/Vonage/Voice/IVoiceClient.cs b/Vonage/Voice/IVoiceClient.cs
@@ -2,8 +2,6 @@
 using Vonage.Common;
 using Vonage.Common.Exceptions;
 using Vonage.Request;
-using Vonage.Voice.Nccos;
-using Vonage.Voice.Nccos.Endpoints;
 
 namespace Vonage.Voice;
 
@@ -12,35 +10,6 @@ namespace Vonage.Voice;
 /// </summary>
 public interface IVoiceClient
 {
-    /// <summary>
-    /// POST /v1/calls - create an outbound SIP or PSTN Call
-    /// </summary>
-    /// <param name="command"></param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <returns></returns>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallResponse CreateCall(CallCommand command, Credentials creds = null);
-
-    /// <summary>
-    /// POST /v1/calls - create an outbound PSTN Call
-    /// </summary>
-    /// <param name="toNumber"></param>
-    /// <param name="fromNumber"></param>
-    /// <param name="ncco"></param>
-    /// <returns></returns>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallResponse CreateCall(string toNumber, string fromNumber, Ncco ncco);
-
-    /// <summary>
-    ///  POST /v1/calls - create an outbound without PSTN Call
-    /// </summary>
-    /// <param name="toEndPoint"></param>
-    /// <param name="fromNumber"></param>
-    /// <param name="ncco"></param>
-    /// <returns></returns>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallResponse CreateCall(Endpoint toEndPoint, string fromNumber, Ncco ncco);
-
     /// <summary>
     /// POST /v1/calls - create an outbound SIP or PSTN Call
     /// </summary>
@@ -50,34 +19,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallResponse> CreateCallAsync(CallCommand command, Credentials creds = null);
 
-    /// <summary>
-    /// POST /v1/calls - create an outbound PSTN Call
-    /// </summary>
-    /// <param name="toNumber"></param>
-    /// <param name="fromNumber"></param>
-    /// <param name="ncco"></param>
-    /// <returns></returns>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    Task<CallResponse> CreateCallAsync(string toNumber, string fromNumber, Ncco ncco);
-
-    /// <summary>
-    ///  POST /v1/calls - create an outbound without PSTN Call
-    /// </summary>
-    /// <param name="toEndPoint"></param>
-    /// <param name="fromNumber"></param>
-    /// <param name="ncco"></param>
-    /// <returns></returns>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    Task<CallResponse> CreateCallAsync(Endpoint toEndPoint, string fromNumber, Ncco ncco);
-
-    /// <summary>
-    /// GET /v1/calls/{uuid} - retrieve information about a single Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallRecord GetCall(string id, Credentials creds = null);
-
     /// <summary>
     /// GET /v1/calls/{uuid} - retrieve information about a single Call
     /// </summary>
@@ -86,14 +27,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallRecord> GetCallAsync(string id, Credentials creds = null);
 
-    /// <summary>
-    /// GET /v1/calls - retrieve information about all your Calls
-    /// <param name="filter">Filter to search calls on</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// </summary>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    PageResponse<CallList> GetCalls(CallSearchFilter filter, Credentials creds = null);
-
     /// <summary>
     /// GET /v1/calls - retrieve information about all your Calls
     /// <param name="filter">Filter to search calls on</param>
@@ -102,15 +35,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<PageResponse<CallList>> GetCallsAsync(CallSearchFilter filter, Credentials creds = null);
 
-    /// <summary>
-    /// GET - retrieves the recording from a call based off of the input url
-    /// </summary>
-    /// <param name="recordingUrl">Url where the recorded call lives</param>
-    /// <param name="creds">Overridden credentials</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    /// <returns>A response containing a byte array representing the file stream</returns>
-    GetRecordingResponse GetRecording(string recordingUrl, Credentials creds = null);
-
     /// <summary>
     /// GET - retrieves the recording from a call based off of the input url
     /// </summary>
@@ -120,15 +44,6 @@ public interface IVoiceClient
     /// <returns>A response containing a byte array representing the file stream</returns>
     Task<GetRecordingResponse> GetRecordingAsync(string recordingUrl, Credentials creds = null);
 
-    /// <summary>
-    /// PUT /v1/calls/{uuid}/dtmf - send Dual-tone multi-frequency(DTMF) tones to an active Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="cmd">Command to execute against call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallCommandResponse StartDtmf(string id, DtmfCommand cmd, Credentials creds = null);
-
     /// <summary>
     /// PUT /v1/calls/{uuid}/dtmf - send Dual-tone multi-frequency(DTMF) tones to an active Call
     /// </summary>
@@ -138,15 +53,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallCommandResponse> StartDtmfAsync(string id, DtmfCommand cmd, Credentials creds = null);
 
-    /// <summary>
-    /// PUT /v1/calls/{uuid}/stream - stream an audio file to an active Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="cmd">Command to execute against call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallCommandResponse StartStream(string id, StreamCommand command, Credentials creds = null);
-
     /// <summary>
     /// PUT /v1/calls/{uuid}/stream - stream an audio file to an active Call
     /// </summary>
@@ -156,15 +62,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallCommandResponse> StartStreamAsync(string id, StreamCommand command, Credentials creds = null);
 
-    /// <summary>
-    /// PUT /v1/calls/{uuid}/talk - send a synthesized speech message to an active Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="cmd">Command to execute against call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallCommandResponse StartTalk(string id, TalkCommand cmd, Credentials creds = null);
-
     /// <summary>
     /// PUT /v1/calls/{uuid}/talk - send a synthesized speech message to an active Call
     /// </summary>
@@ -174,14 +71,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallCommandResponse> StartTalkAsync(string id, TalkCommand cmd, Credentials creds = null);
 
-    /// <summary>
-    /// DELETE /v1/calls/{uuid}/stream - stop streaming an audio file to an active Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallCommandResponse StopStream(string id, Credentials creds = null);
-
     /// <summary>
     /// DELETE /v1/calls/{uuid}/stream - stop streaming an audio file to an active Call
     /// </summary>
@@ -190,14 +79,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallCommandResponse> StopStreamAsync(string id, Credentials creds = null);
 
-    /// <summary>
-    /// DELETE /v1/calls/{uuid}/talk - stop sending a synthesized speech message to an active Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    CallCommandResponse StopTalk(string id, Credentials creds = null);
-
     /// <summary>
     /// DELETE /v1/calls/{uuid}/talk - stop sending a synthesized speech message to an active Call
     /// </summary>
@@ -206,15 +87,6 @@ public interface IVoiceClient
     /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
     Task<CallCommandResponse> StopTalkAsync(string id, Credentials creds = null);
 
-    /// <summary>
-    /// PUT /v1/calls/{uuid} - modify an existing Call
-    /// </summary>
-    /// <param name="id">id of call</param>
-    /// <param name="cmd">Command to execute against call</param>
-    /// <param name="creds">(Optional) Overridden credentials for only this request</param>
-    /// <exception cref="VonageHttpRequestException">thrown if an error is encountered when talking to the API</exception>
-    bool UpdateCall(string id, CallEditCommand command, Credentials creds = null);
-
     /// <summary>
     /// PUT /v1/calls/{uuid} - modify an existing Call
     /// </summary>